fix: respect retries from retryfailedstep plugin in helpers#4028
Merged
kobenguyent merged 1 commit into3.xfrom Nov 29, 2023
Merged
Conversation
kobenguyent
deleted the
3268-argument-retries-for-plugin-retryfailedstep-is-not-working
branch
Contributor
|
@kobenguyent Did you mean FAILED_STEP_RETRIES instead of FAILED_STEP_RETIRES ? |
Collaborator
Author
Thanks @mirao my typo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
retryFailedStepis not working #3268Currently inside the _before() of helpers for example Playwright, the retries is set there https://github.com/codeceptjs/CodeceptJS/blob/3.x/lib/helper/Playwright.js#L477, however, when
retryFailedStepplugin is enabled, the retries of recorder is still using the value from _before() not the value fromretryFailedStepplugin.Fix:
process.env.FAILED_STEP_RETIRESwhich could be access everywhere as the helper won't know anything about the plugin.Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)